Add test for ARRAY.inject(:+) vs ARRAY.sum#140
Open
jrmhaig wants to merge 2 commits intofastruby:mainfrom
Open
Add test for ARRAY.inject(:+) vs ARRAY.sum#140jrmhaig wants to merge 2 commits intofastruby:mainfrom
ARRAY.inject(:+) vs ARRAY.sum#140jrmhaig wants to merge 2 commits intofastruby:mainfrom
Conversation
Author
|
I am surprised to see that this passed in Travis CI even though, in the log with Ruby 2.3.0, there are errors: Is this intended? I expected this error as |
Contributor
|
maybe add a but I'm not a committer, so not sure the official way we do things here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was curious to see the difference between the
summethod in enumerables, which was introduced in Ruby 2.4, and the commonly usedinject(:+). For meinject(:+)is a little bit slower (1.02x).This PR cannot be merged immediately as it will break for Ruby < 2.4. Do you have a way to only run tests for supported versions of Ruby?